search

Stiffstream / restinio

Cross-platform, efficient, customizable, and robust asynchronous HTTP(S)/WebSocket server C++ library with the right balance between performance and ease of use
Other
1.15k stars 93 forks source link

adding a bearer auth parser #92

Closed prince-chrismc closed 4 years ago

prince-chrismc commented 4 years ago

When your code is sooo good it's this easy to expand! :heart:

The only complication with this is the token68 that's defined in RFC 7235 is, as far as i can tell, exactly the same as RFC 6750 b64token. But the names are different :confounded:

If there's any changes I should make to make this match your vision, I will be have happy to apply them.

PS: I have never figured out how to setup the project to run the unit tests, it's just copy paste so fingers crossed.

eao197 commented 4 years ago

I've had changed token68 to b64token where appropriate to use names from RFC. A small bag is also fixed.

eao197 commented 4 years ago

I think that release of v.0.6.7.1 should also contain a fix for that problem. I don't know is it a problem with RESTinio's CMakeLists.txt where dependencies are described, or with Conan recipe, or with CMakeLists.txt from restinio-conan-example.

prince-chrismc commented 4 years ago

I think that release of v.0.6.7.1 should also contain a fix for that problem. I don't know is it a problem with RESTinio's CMakeLists.txt where dependencies are described, or with Conan recipe, or with CMakeLists.txt from restinio-conan-example.

Thankfully it is just an issue with the example, fixes here. The extra cmake calls were picking up a locally installed version of restinio which was not the conan one. Common problem when testing different systems that overlap.

For more assurance moving forward. There's this PR to test the conan package generated, just need to call conan create . for it to be triggered.

eao197 commented 4 years ago

Thanks for your help!