search

Stiffstream / restinio

Cross-platform, efficient, customizable, and robust asynchronous HTTP(S)/WebSocket server C++ library with the right balance between performance and ease of use
Other
1.15k stars 93 forks source link

Please fix CRLF brokenness in your library #97

Closed ned14 closed 4 years ago

ned14 commented 4 years ago

The current inconsistent CRLF makes it painful to use restinio from Linux and Windows off a Samba share.

Here is a suitable .gitattributes to use to ensure broken CRLF never happens again: https://github.com/ned14/restinio/blob/Branch_v.0.6.1.1/.gitattributes

Instructions are here for repairing your existing repo: https://help.github.com/en/github/using-git/configuring-git-to-handle-line-endings

My thanks in advance.

eao197 commented 4 years ago

I've tried. The result is now in 0.6-dev branch.

ned14 commented 4 years ago

That's really great, thank you. You've reduced down my cmake hunter restinio package fork delta now to merely this: https://github.com/Stiffstream/restinio/compare/master...ned14:master

Do you have any objections to your next release being submitted to cmake hunter?

eao197 commented 4 years ago

Do you have any objections to your next release being submitted to cmake hunter?

No.