No longer grabbing highest quality since latest update

[SigismundDijkstra]

Since the update that fixed iTunes it only seems to be grabbing low resolution images. On iTunes it only grabs 500x500 (URL should be 99999x99999 to automatically fetch the highest quality) but it's also occurring on other sites. Soundcloud for example is only fetching 200x200 images now.

[StigNygaard]

Hi @SigismundDijkstra

Thanks for feedback.

iTunes / Apple Music: Are you sure you have the latest version? I just updated Art Grabr yesterday to support the new Apple site. With version 2020.04.25.0 it should work again? If not, it might be because of local differences of the site. What country-version of the site are you using?

SoundCloud: I haven't used Art Grabr myself in a long period, so it is easily possibly support for SoundCloud or other sites have become broken after site-updates. But I just tried finding big artwork on a couple of SoundCloud pages, and it worked fine for me. Can you point me to a page where it doesn't work?

It is also possible that one of the changes I made yesterday also had positive effect on SoundCloud...

PS. What browser are you using? It is also possible that the new version of Art Grabr doesn't support older browsers, like f.ex. IE11. Also, are you using Art Grabr as a bookmarklet or via a userscript manager like Greasemonkey or Tampermonkey?

[SigismundDijkstra]

Sorry, I should have mentioned browser. I'm using Firefox 75 with Tampermonkey.

I have the latest version. I downgraded to the previous version and it's now correctly grabbing the high-res artwork on Soundcloud. I also tested Qobuz and it's the same so it seems to be happening everywhere.

Example: https://www.qobuz.com/gb-en/album/lover-taylor-swift/cp53xl651si5a Latest version grabs: https://static.qobuz.com/images/covers/5a/si/cp53xl651si5a_600.jpg v2019.11.03.0 grabs: https://static.qobuz.com/images/covers/5a/si/cp53xl651si5a_max.jpg

[StigNygaard]

Strange. I have tested successfully, including now your qobuz.com link above, with Firefox75+Greasemonkey and Chrome81+Tampermonkey. Not with your combination, but seems unlikely that should make the difference.

Hmmm... Could I get you to look too see if some javascript error occurs when executing Art Grabr?

You can do it like this:

1) Go to a page like your above mentioned qobuz page. 2) Press F12. This should open Firefox' "developer tools" (see above screenshot). 3) Choose the "Console"-tab in developer tools. 4) Click the Garbagebin icon below the tabs-row to clear any existing content in the console log. 5) Make sure at least the "Errors" button is selected (the button should be dark). 6) Execute Art Grabr trying to find that big cover-art on the qobuz page.

Does it write anything in the Console log when executing Art Grabr?

PS. Use F12 to close developer tools again.

[SigismundDijkstra]

No errors. I tested with Greasemonkey and have the same problem, disabled all other addons and userscripts but it persists. <.<

Works with Chrome + Tampermonkey.

[StigNygaard]

It works for you with Chrome+Tampermonkey?! Hmm, so somehow it doesn't like your Firefox even though you tried Firefox combined with both Greasemonkey and Tampermonkey - and disabled all other addons+userscripts? Really weird...

Is there anything special about your PC? Very small screen? Touch screen? Is it Windows/Mac/Linux? When using Firefox do you see the (first yellow then) red image-borders around the images it tries to update? On a page like f.ex. https://www.last.fm/music/Fiona+Apple/+albums do you get the "20 images requested. Continue?" prompt when running Grabr in Firefox? On https://www.qobuz.com/gb-en/album/lover-taylor-swift/cp53xl651si5a do you get the dimension of image after running Grabr when hovering mouse over the cover? Does it say 1400x1400 or does it say the lower dimensions of the cover you actually get?

[SigismundDijkstra]

Windows 10, latest version. I do get the 20 images requested prompt.

I think I've figured it out though with the hovering. If I wait a moment before clicking it will fetch the high res image (once the image fully loads I guess), but if I click instantly it opens the low res image.

The previous version automatically redirects me to the high res image even if it hasn't loaded.

So it is actually working, I just have to be patient and wait for the images to load now before clicking.

[StigNygaard]

@SigismundDijkstra I did change some things in latest release on how it handles the replacement of images, so it is definitely possible that a little more patience is required. I'm glad we found out what is happening, because for me it was really starting to sound mysterious :-)

I think I will close this issue and call it expected or accepted behaviour. There was some changes in the image-replacement method I had to make in Grabr to make iTunes working again.

Later I might try to get the image-replacement to work faster or smarter, but not sure I will be able to optimize it much.