Closed tschettler closed 2 years ago
Hi, Travis. Thanks for your commits. But we have a problem. In the list of sites, we repeatedly see the same domain. We can do the grouping (as suggested by #47) and then we will see the main domain with an expanded list of nested paths. This is one of the options. We have to think about how to do it better.
p.s. Sorry for my english)
The domain groupings and nested paths is a good idea, but maybe save that for a future change. I'll take a look at fixing it to make sure at least the domains are grouped, thanks for the great feedback!
And no worries, your English is excellent!
Please take another look. This does not include grouping of subdomains, but should fix the regression.
Thanks. These are nice changes for the next grouping function. We now see different times for each tab in the domain.
What we have now.
- Restrictions do not work when we specify only the domain in the list of restrictions.
This does work for me, but I think I may see an issue here and will get it fixed up.
- We have lost the icon with restrictions in the list of sites.
There's a pre-existing race condition on the restriction list when it is initially loaded. You can get the icon if you navigate to another chart and then back. I will work on getting this resolved as well.
These issues should be fixed with #53.
This update refactors URL parsing logic into a separate url class that can be used for comparing both the domain and the path. This allows for setting restrictions by path and domain. For example, one may want to set a restriction for a URL such as
bing.com/fun
, while still allowing unrestricted access to the rest of thebing.com
domain.Adding a restriction for a domain will also restrict subdomain. For example, using the following restriction:
The block page will appear for subdomains as well:
Also fixes a minor off-by-one date parsing issue on the date range. Before:
After:
Open for discussion on this PR, please let me know if there are any issues.
Closes #21, without requiring an asterisk. Also opens up the door for some other feature requests to be implemented more easily (#3, #25, #32, #43, #47).
Thanks in advance for your consideration!
Travis