Stillat / vscode-antlers-language-server

Provides rich language features for Statamic's Antlers templating language, including code completions, syntax highlighting, and more.
https://antlers.dev
MIT License
36 stars 3 forks source link

Additonal closing comment ending on format: #}}#}} #71

Closed johncarter- closed 1 year ago

johncarter- commented 1 year ago

Describe the bug

Showing {{ title }} sector

{{# {{ partial src="default" }} #}}

Formats to:

Showing {{ title }} sector

{{# {{ partial src="default" }} #}}#}}

Impacted Products Which Antlers Toolbox products does this bug apply to?

Versions and Other Plugins/Extensions v2.6.0

To Reproduce

Expected behavior

Showing {{ title }} sector

{{# {{ partial src="default" }} #}}

If submitting a formatting bug, please include the template contents below as well as an attachment Add any problematic templates here.

Additional context Add any other context about the problem here.

JohnathonKoster commented 1 year ago

Hey there!

I cannot reproduce using just the submitted template. Would you able to share more of the template where this issue was observed?

Thanks!

johncarter- commented 1 year ago

Thanks a lot John. I'll dig it out tomorrow, but I'm pretty sure that's the entire template.

On Mon, 1 May 2023, 20:57 John Koster, @.***> wrote:

Hey there!

I cannot reproduce using just the submitted template. Would you able to share more of the template where this issue was observed?

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/Stillat/vscode-antlers-language-server/issues/71#issuecomment-1530134913, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA42C6DHFYYEVDUJYGI625DXEAIRLANCNFSM6AAAAAAXSDFR7I . You are receiving this because you authored the thread.Message ID: @.***>

JohnathonKoster commented 1 year ago

Sounds good; let me know if you find anything else that might help!

johncarter- commented 1 year ago

Yep that's the entire template. I don't know if there is any more info I could provide to you?

Code_LbYdf3dGyh

JohnathonKoster commented 1 year ago

Thanks for the video/screen clip! It's the newline at the end that will trigger this. I'll look into a fix 🙂

JohnathonKoster commented 1 year ago

Should be good to go in Antlers Toolbox 2.6.1, as well as the following:

antlers-formatter: 1.2.5 prettier-plugin-antlers: 1.2.5 antlers-language-server: 1.3.1

johncarter- commented 1 year ago

Thanks so much John.