search

Stillat / vscode-antlers-language-server

Provides rich language features for Statamic's Antlers templating language, including code completions, syntax highlighting, and more.
https://antlers.dev
MIT License
36 stars 3 forks source link

Underlines appear strangely in code #92

Closed replete closed 2 months ago

replete commented 2 months ago

Describe the bug Some tags in HTML views appear unexpectedly underlined Screenshot 2024-07-06 at 16 35 12

Impacted Products Which Antlers Toolbox products does this bug apply to?

Versions and Other Plugins/Extensions Please include the product version you are reporting a bug for. If you are reporting a bug for products such as Antlers Toolbox for VS Code or the Antlers Prettier Plugin, please include a list of other configured extensions or plugins if you believe they are contributing to the problematic behavior.

VSCodium 1.90.2 (I appreciate you might not want to support this build of vscode, but I thought it best to report it anyway, vscodium is a straight build of vscode without the trackers and non-FLOSS microsoft licensing and most plugins work the same)

To Reproduce Install plugin. Appears fine initially, then underlines appear along with warnings

Expected behavior A clear and concise description of what you expected to happen.

No underlines should appear anywhere.

If submitting a formatting bug, please include the template contents below as well as an attachment Add any problematic templates here.

Additional context Add any other context about the problem here.

JohnathonKoster commented 2 months ago

VS Code underlines things it thinks are links, such as the content in the href="" of HTML tags. The partial is underlined since the language server itself made those into links, and can use the configured shortcut to navigate to the source of that partial.

replete commented 2 months ago

I thought it was an error here because the underline starts at the second curly brace.

Screenshot 2024-07-06 at 17 35 02

JohnathonKoster commented 2 months ago

Just a small offset thing. Do you see any errors in the problems window when it shows up?

replete commented 2 months ago

No problems. I thought I had an extension compatibility issue, but had the same behaviour with extensions disabled.

While I'm here, is it possible to disable this newline-in-curly-brace behaviour when in script or style tags? Screenshot 2024-07-07 at 11 13 53

Cheers for creating this extension!