search

Stillat / vscode-antlers-language-server

Provides rich language features for Statamic's Antlers templating language, including code completions, syntax highlighting, and more.
https://antlers.dev
MIT License
36 stars 3 forks source link

Syntax highlighting is broken when using frontmatter (after upgrading to VS Code 1.92) #94

Closed eminos closed 1 month ago

eminos commented 1 month ago

Describe the bug Seems the syntax highlighting is somewhat broken after upgrading to VS Code 1.92. Having a frontmatter on the antlers file breaks the syntax highlighting. Or to be more precise, having more then one line

This works: image

This breaks it: image

Impacted Products Antlers Toolbox for VS Code

Versions and Other Plugins/Extensions VS Code 1.92.0 Antlers Toolbox v2.6.19

eminos commented 1 month ago

Removed a few unrelated extensions, restarted VS Code, and now it's all back to normal... Seems to have updated VS Code to 1.92.1 as well. I have non idea what actually solved it. It has probably nothing to do with this extension 🙂

JohnathonKoster commented 1 month ago

Interesting! Thanks for updating the issue, though 🙏

RedCMD commented 3 weeks ago

caused by https://github.com/microsoft/vscode/pull/219833

you will need to update your frontMatter integration to something like https://github.com/microsoft/vscode-markdown-tm-grammar/pull/162 https://github.com/Stillat/vscode-antlers-language-server/blob/157d0eac3de834662d8616fdc828f554b8a73095/client/syntaxes/antlers.json#L123-L132

before VSCode re-adds the new YAML grammar again

related: https://github.com/microsoft/vscode/issues/224862

JohnathonKoster commented 3 weeks ago

Thank you for the extra info!