Closed Gaurav17Joshi closed 1 year ago
I reran the whole notebook again, and it was giving this errors:-
1) In Fit Peak with Sinc Squared and Gaussian function, there was an error in line
plt.axvline(fs.mean, label='Fit frequency')
,
as fs.mean is an astropy class and not a float, this was solved by adding fs.mean[0]
2) The main problem with the document was that the plot profiles (in Pulsation search with epoch folding) were made on the same plot, while the codes were written in different cells, this can be changed by writing codes for both plots in the same cell, but that would change the flow of the document. What do you think should be done, I suggest that we shift the line (where the pulse was plotted twice for visual clarity. If the candidate pulse frequency was even slightly incorrect, we would have obtained a much shallower pulse profile, or no pulse profile at all. E.g,) to be before the plot
Rest of the notebook is working as expected.
@matteobachetti , I have made the necessary changes to my file, and ran the full notebook again, it works on my side, can you please check it.
Ok, seems good. Thanks @Gaurav17Joshi !
Pulsar Document Update
Addressing #44, I have updated the module call for
fold_detection_level, z2_n_detection_level
formstingray.pulse.pulsar
tostingray.stats
. Have also changed that part in the document and removed the unwanted extra space above the first epoch folding plot.