search

StingraySoftware / stingray

Anything can happen in the next half hour (including spectral timing made easy)!
https://stingray.science/stingray
MIT License
172 stars 141 forks source link

Travis-CI not enabled #43

Closed OrkoHunter closed 8 years ago

OrkoHunter commented 8 years ago

Hello Developers,

Tests must be run on every Pull Request before they are merged. I see a .travis.yml file in the repo but Travis did not run on #42. I think the integration is not done yet for this repository.

matteobachetti commented 8 years ago

Hi @OrkoHunter, as you see, it's in the works. The plan is to rework the repository following the Astropy template and then make use of the Astropy ci-helpers for this.

OrkoHunter commented 8 years ago

Awesome ! Let's set up Travis now. We can have a look at the build on my fork here. https://travis-ci.org/OrkoHunter/stingray

evandromr commented 8 years ago

I was just thinking if we should also rework the test suite to match astropy's py.test, instead of nosetests before tackling Issue #44

Thoughts?

OrkoHunter commented 8 years ago

@evandromr py.test is a great test suite. But If we see some strong reasons to move away from nosetests, then we must move. Anything in particular?

PS. numpy.testing is also famous in the SciPy community.

evandromr commented 8 years ago

@OrkoHunter nothing in particular. Just thinking in long-term development, if we want to keep the structure and workflow close to Astropy's standard than it is better to make changes now, in the beginning, than later. This would allow us, for example, to make stingray an affiliated Astropy package without much work. And new collaborators would have an already established documentation on how to contribute to the project.

OrkoHunter commented 8 years ago

+1 If other devs agree, I am willing to help in the issue.

matteobachetti commented 8 years ago

@evandromr thanks for pointing that out. Sticking to the astropy standard is a priority.

dhuppenkothen commented 8 years ago

@OrkoHunter are you working on the travis integration? I've set up the repository access on Travis, but the build fails for various reasons. Would you be willing to help us getting that up and running? My knowledge of Travis is pretty rudimentary, but I'm happy to help where I can.

Let's keep the changes to the testing module separate from this issue about Travis integration.

matteobachetti commented 8 years ago

@dhuppenkothen @OrkoHunter I think this should go together with the astropy-like template and use Astropy's ci-helpers, in order not to duplicate the efforts.

I did that for Maltpynt, and that was totally worth it. In that repo you can see the kind of formatting required for Travis and Appveyor, it is much slicker. Also ci-helpers deals with most software upgrades of the testing platforms transparently from the user.

OrkoHunter commented 8 years ago

@dhuppenkothen Yes, I'm okay to help setup Travis-CI. Would you mind running the tests locally for once? They failed for me (Ref #44 ). That would be great. @matteobachetti Yes, we'll stick with how AstroPy does it. :)

OrkoHunter commented 8 years ago

Enabled in #52.