search

StingraySoftware / stingray

Anything can happen in the next half hour (including spectral timing made easy)!
https://stingray.science/stingray
MIT License
172 stars 141 forks source link

Change confusing default value of segment_size #670

Closed matteobachetti closed 2 years ago

matteobachetti commented 2 years ago

With reference to #667 and other similar issues reported over the years, I think it is just better to give segment_size an infinite default value, and only people who know what they are doing can set it to a lower value. Giving 5000 as a default value does not make sense

codecov[bot] commented 2 years ago

Codecov Report

Merging #670 (9024e77) into main (f7c981d) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 9024e77 differs from pull request most recent head 61d4e48. Consider uploading reports for the commit 61d4e48 to get more accurate results

@@           Coverage Diff           @@
##             main     #670   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files          42       42           
  Lines        7644     7644           
=======================================
  Hits         7426     7426           
  Misses        218      218
Impacted Files Coverage Δ
stingray/pulse/search.py 96.62% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more