StingraySoftware / stingray

Anything can happen in the next half hour (including spectral timing made easy)!
https://stingray.science/stingray
MIT License
172 stars 141 forks source link

Separate docs build from standard CI; add link check #743

Closed matteobachetti closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #743 (e629709) into main (bd7dadf) will not change coverage. The diff coverage is n/a.

:exclamation: Current head e629709 differs from pull request most recent head fb3172d. Consider uploading reports for the commit fb3172d to get more accurate results

@@           Coverage Diff           @@
##             main     #743   +/-   ##
=======================================
  Coverage   97.12%   97.12%           
=======================================
  Files          42       42           
  Lines        7884     7884           
=======================================
  Hits         7657     7657           
  Misses        227      227           
Files Changed Coverage Δ
stingray/modeling/parameterestimation.py 86.03% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

matteobachetti commented 1 year ago

@jdswinbank I can't make it skip standard ci tests with [docs only], as it was in old versions of the package template. Any idea how to fix this?

matteobachetti commented 1 year ago

Nice. It looks like the words "skip ci" stop the ci_tests from starting, but not the docs ones. So, it does make sense to separate the tests after all. If this mechanism is repeatable, I will add a note in the developer docs saying to add "skip ci" to just run the doc tests.

matteobachetti commented 1 year ago

Looks like the mechanism is repeatable. Merging. Thanks @jdswinbank!