search

StingraySoftware / stingray

Anything can happen in the next half hour (including spectral timing made easy)!
https://stingray.science/stingray
MIT License
172 stars 141 forks source link

Colors (as in color-color or hardness-intensity diagrams) #781

Closed matteobachetti closed 8 months ago

matteobachetti commented 10 months ago

~Depends on #754~

pep8speaks commented 10 months ago

Hello @matteobachetti! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-01-15 10:50:12 UTC
codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1fc9b90) 79.07% compared to head (115b9e6) 93.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #781 +/- ## =========================================== + Coverage 79.07% 93.98% +14.91% =========================================== Files 43 43 Lines 8697 8762 +65 =========================================== + Hits 6877 8235 +1358 + Misses 1820 527 -1293 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

matteobachetti commented 8 months ago

@dhuppenkothen the problem is that some missions do not declare a time resolution. What do you use for dt then? 0 means simply that there is no known time resolution, or that it's probably irrelevant for the purpose of the analysis.

matteobachetti commented 8 months ago

Ok, I changed the logic to eliminate some of the confusion, and eliminated method-level imports as promised ;)

matteobachetti commented 8 months ago

~Note to self: fix the return value in the docstring of get_intensity_evolution~ Done