search

StingraySoftware / stingray

Anything can happen in the next half hour (including spectral timing made easy)!
https://stingray.science/stingray
MIT License
166 stars 137 forks source link

More informative GTI failure #787

Closed matteobachetti closed 6 months ago

matteobachetti commented 6 months ago

Responding to an issue by G.L. Israel, I substituted a generic exception with a full traceback of what goes wrong when GTIs are not correctly read.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cc9d575) 96.31% compared to head (065e3cc) 96.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #787 +/- ## ======================================= Coverage 96.31% 96.31% ======================================= Files 43 43 Lines 8495 8497 +2 ======================================= + Hits 8182 8184 +2 Misses 313 313 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pep8speaks commented 6 months ago

Hello @matteobachetti! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-01-02 17:01:33 UTC
matteobachetti commented 6 months ago

@mgullik indeed, there is a keyword, gtistring, that allows the user to provide a number of comma-separated strings for GTI extensions. The default is "GTI,STDGTI", or whatever the default for a given mission is