search

StingraySoftware / stingray

Anything can happen in the next half hour (including spectral timing made easy)!
https://stingray.science/stingray
MIT License
172 stars 141 forks source link

Fix issue with Poisson noise in lag spectra #789

Closed matteobachetti closed 8 months ago

matteobachetti commented 8 months ago

Resolve #741

We had a bug in the calculation of the Poisson noise level, which was highly overestimated. This produced some wrong results in the error calculation.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a4cafa4) 92.79% compared to head (90cb085) 93.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #789 +/- ## ========================================== + Coverage 92.79% 93.46% +0.66% ========================================== Files 43 43 Lines 8762 8762 ========================================== + Hits 8131 8189 +58 + Misses 631 573 -58 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

matteobachetti commented 8 months ago

I think that it just makes little difference in the high-SNR case that we test. Yes, Ideally we should have caught this before :(