StingraySoftware / stingray

Anything can happen in the next half hour (including spectral timing made easy)!
https://stingray.science/stingray
MIT License
166 stars 137 forks source link

Fix compute rms #792

Closed matteobachetti closed 5 months ago

matteobachetti commented 5 months ago

I also had to fix a couple of things related to warnings, because the new pytest is much pickier. All the changes to warnings (and to imports in the top of files) are due to that. Please ignore for the sake of this PR. Only consider changes to (test_)crossspectrum, powerspectrum, fourier, and minor related changes in multitaper, lombscargle and deadtime.

Resolve #790

codecov[bot] commented 5 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6f38ba2) 78.98% compared to head (02fe583) 95.83%.

:exclamation: Current head 02fe583 differs from pull request most recent head 10764e4. Consider uploading reports for the commit 10764e4 to get more accurate results

Files Patch % Lines
stingray/crossspectrum.py 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #792 +/- ## =========================================== + Coverage 78.98% 95.83% +16.84% =========================================== Files 43 43 Lines 8762 8784 +22 =========================================== + Hits 6921 8418 +1497 + Misses 1841 366 -1475 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pep8speaks commented 5 months ago

Hello @matteobachetti! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1713:101: E501 line too long (101 > 100 characters) Line 1734:101: E501 line too long (101 > 100 characters)

Comment last updated at 2024-01-29 14:44:59 UTC