codecov[bot]
commented
4 months ago Codecov Report
Attention: Patch coverage is 98.67550% with 2 lines in your changes are missing coverage. Please review.
Project coverage is 94.52%. Comparing base (
de9400a) to head (baa5060).:exclamation: Current head baa5060 differs from pull request most recent head 370bd9c. Consider uploading reports for the commit 370bd9c to get more accurate results
| Files | Patch % | Lines |
|---|---|---|
| stingray/deadtime/model.py | 98.40% | 2 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #800 +/- ## ========================================== - Coverage 96.43% 94.52% -1.91% ========================================== Files 45 45 Lines 9034 9135 +101 ========================================== - Hits 8712 8635 -77 - Misses 322 500 +178 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
pep8speaks
The dead time model had a few issues:
the sum of many values below computer precision which produced large errors in the final result -> I set a limit for new additions so that numbers get only added when larger than
10**(-np.finfo(float).precision)check_Aandcheck_Bhad useless axes in some conditions due to the large dynamic range of values -> I changed them to "symlog" to allow for negative numbers with small powers of ten.Also in this PR:
Added the possibility of calculating
BandAfor ranges of the parameterkAdded a new functions that calculates the deadtime-distorted PDS with more user-friendly parameters (e.g. providing the frequency array, starting from detected (not incident) count rate, using background to rescale, etc.)
Added a method to Crossspectrum and derivatives to directly correct the powers, assuming a constant dead time