search

StingraySoftware / stingray

Anything can happen in the next half hour (including spectral timing made easy)!
https://stingray.science/stingray
MIT License
166 stars 137 forks source link

Add calibration with RMF file #804

Closed matteobachetti closed 3 months ago

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.42%. Comparing base (e0b10f1) to head (ba6cc47).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #804 +/- ## ========================================== + Coverage 96.41% 96.42% +0.01% ========================================== Files 45 45 Lines 8989 9016 +27 ========================================== + Hits 8667 8694 +27 Misses 322 322 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

matteobachetti commented 4 months ago

@mgullik good catch on the default_nustar_rmf, it was a leftover from HENDRICS' documentation with no real effect. I added the possibility to calibrate directly at read or initialization, I agree it's a simple and very useful addition.

matteobachetti commented 4 months ago

The test rmf file is just taken from an old NuSTAR observation, I don't remember the details 😅