search

StingraySoftware / stingray

Anything can happen in the next half hour (including spectral timing made easy)!
https://stingray.science/stingray
MIT License
172 stars 141 forks source link

Fits event lists #834

Open matteobachetti opened 1 month ago

matteobachetti commented 1 month ago

Introduces a new FITS reader class, that lazy loads the data until a slice is required (in which case, the wanted StingrayTimeseries object is created).

pep8speaks commented 1 month ago

Hello @matteobachetti! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 634:80: E501 line too long (87 > 79 characters)

Line 1736:80: E501 line too long (98 > 79 characters) Line 1763:80: E501 line too long (91 > 79 characters) Line 1770:80: E501 line too long (83 > 79 characters) Line 1771:80: E501 line too long (91 > 79 characters) Line 1783:80: E501 line too long (87 > 79 characters) Line 1788:80: E501 line too long (86 > 79 characters) Line 1794:80: E501 line too long (83 > 79 characters) Line 1807:80: E501 line too long (87 > 79 characters) Line 1809:80: E501 line too long (98 > 79 characters) Line 1812:80: E501 line too long (85 > 79 characters) Line 1829:80: E501 line too long (96 > 79 characters) Line 1844:80: E501 line too long (100 > 79 characters)

Line 789:80: E501 line too long (100 > 79 characters) Line 815:80: E501 line too long (83 > 79 characters) Line 829:80: E501 line too long (80 > 79 characters) Line 867:80: E501 line too long (92 > 79 characters) Line 871:80: E501 line too long (89 > 79 characters) Line 919:80: E501 line too long (87 > 79 characters) Line 922:80: E501 line too long (89 > 79 characters) Line 927:80: E501 line too long (89 > 79 characters) Line 971:80: E501 line too long (97 > 79 characters) Line 994:31: E203 whitespace before ':' Line 997:80: E501 line too long (83 > 79 characters) Line 998:80: E501 line too long (101 > 79 characters) Line 1003:80: E501 line too long (86 > 79 characters) Line 1004:80: E501 line too long (80 > 79 characters) Line 1015:80: E501 line too long (82 > 79 characters) Line 1029:80: E501 line too long (89 > 79 characters) Line 1043:80: E501 line too long (88 > 79 characters) Line 1045:33: E203 whitespace before ':' Line 1070:80: E501 line too long (87 > 79 characters) Line 1084:80: E501 line too long (92 > 79 characters) Line 1085:80: E501 line too long (97 > 79 characters) Line 1095:80: E501 line too long (82 > 79 characters) Line 1110:80: E501 line too long (90 > 79 characters) Line 1112:80: E501 line too long (96 > 79 characters) Line 1118:80: E501 line too long (96 > 79 characters) Line 1123:80: E501 line too long (82 > 79 characters) Line 1136:80: E501 line too long (81 > 79 characters) Line 1137:80: E501 line too long (84 > 79 characters)

Line 184:80: E501 line too long (82 > 79 characters) Line 185:80: E501 line too long (86 > 79 characters)

Line 335:80: E501 line too long (84 > 79 characters) Line 349:80: E501 line too long (80 > 79 characters) Line 354:80: E501 line too long (88 > 79 characters) Line 361:80: E501 line too long (92 > 79 characters) Line 367:80: E501 line too long (87 > 79 characters)

Line 37:80: E501 line too long (84 > 79 characters) Line 39:80: E501 line too long (83 > 79 characters) Line 41:80: E501 line too long (91 > 79 characters)

Line 369:80: E501 line too long (83 > 79 characters) Line 375:80: E501 line too long (81 > 79 characters) Line 381:80: E501 line too long (81 > 79 characters)

Line 236:80: E501 line too long (87 > 79 characters) Line 249:80: E501 line too long (88 > 79 characters)

Comment last updated at 2024-09-30 19:03:55 UTC
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 8.06452% with 285 lines in your changes missing coverage. Please review.

Project coverage is 47.09%. Comparing base (241f81a) to head (f8fe13b). Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
stingray/io.py 8.83% 196 Missing :warning:
stingray/gti.py 4.76% 60 Missing :warning:
stingray/mission_support/rxte.py 9.09% 20 Missing :warning:
stingray/events.py 11.11% 8 Missing :warning:
stingray/mission_support/missions.py 0.00% 1 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (241f81a) and HEAD (f8fe13b). Click for more details.

HEAD has 85 uploads less than BASE | Flag | BASE (241f81a) | HEAD (f8fe13b) | |------|------|------| ||86|1|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #834 +/- ## =========================================== - Coverage 96.53% 47.09% -49.44% =========================================== Files 48 48 Lines 9257 9584 +327 =========================================== - Hits 8936 4514 -4422 - Misses 321 5070 +4749 ``` | [Flag](https://app.codecov.io/gh/StingraySoftware/stingray/pull/834/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StingraySoftware) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/StingraySoftware/stingray/pull/834/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StingraySoftware) | `47.09% <8.06%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StingraySoftware#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.