search

StjerneIdioten / I3D-Blender-Addon

Rewriting the I3D blender addon from scratch and adding long-sought community features
GNU General Public License v3.0
66 stars 18 forks source link

[Bug Report] Path logic is case-sensitive #132

Open StjerneIdioten opened 3 years ago

StjerneIdioten commented 3 years ago

Describe the bug

When setting up the FS-Path and adding files etc. if they differ in case in any way, then the exporter won't do the $data replacement. This shouldn't matter since windows is in fact, case-insensitive.

So eg. "S:\Steam\steamapps" wouldn't be the same as "s:\steam\steamapps" to the exporter, even though they are (On a windows system at least)

jtsage commented 2 years ago

Cruising through to write feature requests - but my input, should you want it - agree 100% with your use case here - but be careful, because while windows is case insensitive, file names in ZIP archives are not in the giants engine (19 & 22) - so be wary of rewriting any "local" paths. :)

StjerneIdioten commented 2 years ago

For the new stuff the original concern is more or less going to be a non-issue. The exporter currently uses plain strings for resolving paths, where as for the new one I am using python Paths, which handles all of the potential case insensitivity etc.

It is probably worth making sure that it won't rewrite anything past the $data directory or within the mods source directory, but at the moment I don't do that anyway, it just doesn't check for string equality between cases.