search

StjerneIdioten / I3D-Blender-Addon

Rewriting the I3D blender addon from scratch and adding long-sought community features
GNU General Public License v3.0
66 stars 18 forks source link

Fix shader node inputs for Blender 4.0 #189

Closed LKAMinco closed 9 months ago

LKAMinco commented 9 months ago

Fix to support materials export for Blender 4.0 with support for older versions.

Blender 4.0 change in Shader input naming: Specular -> Specular IOR Level Emission -> Emission Color

Fix Emissive color export since new blender has by default Emissive color 1 1 1 1. Now is emissive color exported when strength has non zero value

ssnd292 commented 9 months ago

@LKAMinco Please test the commits before pushing, use the ammend commit feature or merge the final commit from a dev branch into the merge branch.

The last commits generated quite some email spam.

LKAMinco commented 9 months ago

Ohh yep, sorry :( thats because i have edited it from github not from my computer. I'll get better.

StjerneIdioten commented 9 months ago

@LKAMinco Please test the commits before pushing, use the ammend commit feature or merge the final commit from a dev branch into the merge branch.

You can also create a series of local commits (Don't push) and test your stuff. Then at the end do an interactive rebase and merge everything into one commit before pushing it 😉

Github states that it is possible to "add suggestion to batch", which will then group all of this stuff into one commit that you can then apply, allowing @ssnd292 to keep his sanity 🤣

ssnd292 commented 9 months ago

@LKAMinco Please test the commits before pushing, use the ammend commit feature or merge the final commit from a dev branch into the merge branch.

You can also create a series of local commits (Don't push) and test your stuff. Then at the end do an interactive rebase and merge everything into one commit before pushing it 😉

This is exactly what Ammend Commit already does :D

StjerneIdioten commented 9 months ago

This is exactly what Ammend Commit already does :D

Yes and no. Ammend commmit will immediately rewrite your existing commit. So you will be folding in the changes every time you do one. Interactively rebasing at the end (to one single commit) you can keep individual commits around while working. You can also do a mixture depending on how you like to work 😂 I don't care much as long as it is kept locally 😉