Closed rye closed 6 years ago
I'm gonna venture that it has something to do with:
AndroidRuntime
crash trace.11-10 01:51:57.539 5114 5134 E AndroidRuntime: FATAL EXCEPTION: Thread-2 11-10 01:51:57.539 5114 5134 E AndroidRuntime: Process: com.allaboutolaf, PID: 5114 11-10 01:51:57.539 5114 5134 E AndroidRuntime: java.lang.NoClassDefFoundError: Failed resolution of: Lcom/google/android/gms/maps/GoogleMapOptions; 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at com.airbnb.android.react.maps.AirMapManager.(AirMapManager.java:52) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at com.airbnb.android.react.maps.MapsPackage.createViewManagers(MapsPackage.java:39) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at com.facebook.react.ReactInstanceManager.createAllViewManagers(ReactInstanceManager.java:655) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at com.facebook.react.CoreModulesPackage.createUIManager(CoreModulesPackage.java:227) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at com.facebook.react.CoreModulesPackage.access$200(CoreModulesPackage.java:76) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at com.facebook.react.CoreModulesPackage$8.get(CoreModulesPackage.java:153) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at com.facebook.react.CoreModulesPackage$8.get(CoreModulesPackage.java:150) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at com.facebook.react.LazyReactPackage.createNativeModules(LazyReactPackage.java:82) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at com.facebook.react.NativeModuleRegistryBuilder.processPackage(NativeModuleRegistryBuilder.java:106) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at com.facebook.react.ReactInstanceManager.processPackage(ReactInstanceManager.java:1009) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at com.facebook.react.ReactInstanceManager.createReactContext(ReactInstanceManager.java:933) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at com.facebook.react.ReactInstanceManager.access$600(ReactInstanceManager.java:109) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at com.facebook.react.ReactInstanceManager$4.run(ReactInstanceManager.java:746) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at java.lang.Thread.run(Thread.java:764) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: Caused by: java.lang.ClassNotFoundException: com.google.android.gms.maps.GoogleMapOptions 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at java.lang.VMClassLoader.findLoadedClass(Native Method) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at java.lang.ClassLoader.findLoadedClass(ClassLoader.java:738) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at java.lang.ClassLoader.loadClass(ClassLoader.java:363) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at java.lang.ClassLoader.loadClass(ClassLoader.java:312) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: ... 14 more 11-10 01:51:57.539 5114 5134 E AndroidRuntime: Caused by: java.lang.NoClassDefFoundError: Failed resolution of: Lcom/google/android/gms/common/internal/safeparcel/zza; 11-10 01:51:57.539 5114 5134 E AndroidRuntime: ... 14 more 11-10 01:51:57.539 5114 5134 E AndroidRuntime: Caused by: java.lang.ClassNotFoundException: Didn't find class "com.google.android.gms.common.internal.safeparcel.zza" on path: DexPathList[[zip file "/data/app/com.allaboutolaf-w2SIV_V0DGS4CaY36VQmFA==/base.apk"],nativeLibraryDirectories=[/data/app/com.allaboutolaf-w2SIV_V0DGS4CaY36VQmFA==/lib/x86, /system/fake-libs, /data/app/com.allaboutolaf-w2SIV_V0DGS4CaY36VQmFA==/base.apk!/lib/x86, /system/lib, /system/vendor/lib]] 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:93) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at java.lang.ClassLoader.loadClass(ClassLoader.java:379) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: at java.lang.ClassLoader.loadClass(ClassLoader.java:312) 11-10 01:51:57.539 5114 5134 E AndroidRuntime: ... 14 more
Just to be clear, 2.4.1 is crashing? Or 2.4.2-beta.1?
2.4.2-pre
is.
git bisect
kristofer@maero ~/G/G/S/AAO-React-Native ((f1c9cd62…)|BISECTING)> git bisect bad f1c9cd621619b975f46047923fff28d607b7e7f7 is the first bad commit commit f1c9cd621619b975f46047923fff28d607b7e7f7 Author: greenkeeper[bot]Date: Tue Nov 7 16:37:05 2017 +0000 fix(package): update bugsnag-react-native to version 2.6.0 Closes #1837 :100644 100644 3b2a4d8a16cdfa05fef254efe5993b09e9fb9802 8e7187f2c8d90913a716b0f62f4356905f616923 M package.json
Confirmed that this was a result of #1850—builds on top of master
with those three commits reverted.
It seems as though this has something to do with adding Google's Gradle repository. I confirmed that downgrading back to v2.5.1
works fine, even with the work done on master
.
See also this comment on an issue that was created regarding doing this upgrade without adding Google's Maven repository.
./gradlew :app:dependencies
./gradlew :app:dependencies
PR incoming to fix the broken Android app. We should open another issue for this bugsnag-react-native
upgrade trouble.
Red is with the maven repo and bugsnag 2.6; green is without and with bugsnag 2.5.1.
7,8c7,8
< | +--- com.bugsnag:bugsnag-android:4.1.3
< | | \--- com.android.support:support-annotations:27.0.0
---
> | +--- com.bugsnag:bugsnag-android:4.1.0
> | | \--- com.android.support:support-annotations:25.3.1
14c14
< | | | \--- com.android.support:support-annotations:25.2.0 -> 27.0.0
---
> | | | \--- com.android.support:support-annotations:25.2.0 -> 25.3.1
16c16
< | | | +--- com.android.support:support-annotations:25.2.0 -> 27.0.0
---
> | | | +--- com.android.support:support-annotations:25.2.0 -> 25.3.1
19c19
< | | | +--- com.android.support:support-annotations:25.2.0 -> 27.0.0
---
> | | | +--- com.android.support:support-annotations:25.2.0 -> 25.3.1
22c22
< | | | +--- com.android.support:support-annotations:25.2.0 -> 27.0.0
---
> | | | +--- com.android.support:support-annotations:25.2.0 -> 25.3.1
61c61
< | | \--- com.android.support:support-annotations:25.0.1 -> 27.0.0
---
> | | \--- com.android.support:support-annotations:25.0.1 -> 25.3.1
65,79c65,74
< | \--- com.google.android.gms:play-services-gcm:+ -> 11.6.0
< | +--- com.google.android.gms:play-services-base:11.6.0
< | | +--- com.google.android.gms:play-services-basement:11.6.0
< | | | +--- com.android.support:support-v4:25.2.0 (*)
< | | | \--- com.google.android.gms:play-services-basement-license:11.6.0
< | | +--- com.google.android.gms:play-services-tasks:11.6.0
< | | | +--- com.google.android.gms:play-services-basement:11.6.0 (*)
< | | | \--- com.google.android.gms:play-services-tasks-license:11.6.0
< | | \--- com.google.android.gms:play-services-base-license:11.6.0
< | +--- com.google.android.gms:play-services-basement:11.6.0 (*)
< | +--- com.google.android.gms:play-services-iid:11.6.0
< | | +--- com.google.android.gms:play-services-base:11.6.0 (*)
< | | +--- com.google.android.gms:play-services-basement:11.6.0 (*)
< | | \--- com.google.android.gms:play-services-iid-license:11.6.0
< | \--- com.google.android.gms:play-services-gcm-license:11.6.0
---
> | \--- com.google.android.gms:play-services-gcm:+ -> 11.0.4
> | +--- com.google.android.gms:play-services-base:11.0.4
> | | +--- com.google.android.gms:play-services-basement:11.0.4
> | | | \--- com.android.support:support-v4:25.2.0 (*)
> | | \--- com.google.android.gms:play-services-tasks:11.0.4
> | | \--- com.google.android.gms:play-services-basement:11.0.4 (*)
> | +--- com.google.android.gms:play-services-basement:11.0.4 (*)
> | \--- com.google.android.gms:play-services-iid:11.0.4
> | +--- com.google.android.gms:play-services-base:11.0.4 (*)
> | \--- com.google.android.gms:play-services-basement:11.0.4 (*)
82,94c77,86
< | \--- com.google.android.gms:play-services-analytics:+ -> 11.6.0
< | +--- com.google.android.gms:play-services-analytics-impl:11.6.0
< | | +--- com.google.android.gms:play-services-base:11.6.0 (*)
< | | +--- com.google.android.gms:play-services-basement:11.6.0 (*)
< | | \--- com.google.android.gms:play-services-analytics-impl-license:11.6.0
< | +--- com.google.android.gms:play-services-base:11.6.0 (*)
< | +--- com.google.android.gms:play-services-basement:11.6.0 (*)
< | +--- com.google.android.gms:play-services-tagmanager-v4-impl:11.6.0
< | | +--- com.google.android.gms:play-services-analytics-impl:11.6.0 (*)
< | | +--- com.google.android.gms:play-services-base:11.6.0 (*)
< | | +--- com.google.android.gms:play-services-basement:11.6.0 (*)
< | | \--- com.google.android.gms:play-services-tagmanager-v4-impl-license:11.6.0
< | \--- com.google.android.gms:play-services-analytics-license:11.6.0
---
> | \--- com.google.android.gms:play-services-analytics:+ -> 11.0.4
> | +--- com.google.android.gms:play-services-analytics-impl:11.0.4
> | | +--- com.google.android.gms:play-services-base:11.0.4 (*)
> | | \--- com.google.android.gms:play-services-basement:11.0.4 (*)
> | +--- com.google.android.gms:play-services-base:11.0.4 (*)
> | +--- com.google.android.gms:play-services-basement:11.0.4 (*)
> | \--- com.google.android.gms:play-services-tagmanager-v4-impl:11.0.4
> | +--- com.google.android.gms:play-services-analytics-impl:11.0.4 (*)
> | +--- com.google.android.gms:play-services-base:11.0.4 (*)
> | \--- com.google.android.gms:play-services-basement:11.0.4 (*)
101c93
< | +--- com.google.android.gms:play-services-base:10.2.4 -> 11.6.0 (*)
---
> | +--- com.google.android.gms:play-services-base:10.2.4 -> 11.0.4 (*)
103,104c95,96
< | +--- com.google.android.gms:play-services-base:10.2.4 -> 11.6.0 (*)
< | \--- com.google.android.gms:play-services-basement:10.2.4 -> 11.6.0 (*)
---
> | +--- com.google.android.gms:play-services-base:10.2.4 -> 11.0.4 (*)
> | \--- com.google.android.gms:play-services-basement:10.2.4 -> 11.0.4 (*)
110,116c102,107
< | +--- com.google.android.gms:play-services-gcm:+ -> 11.6.0 (*)
< | +--- com.google.android.gms:play-services-analytics:+ -> 11.6.0 (*)
< | \--- com.google.android.gms:play-services-location:+ -> 11.6.0
< | +--- com.google.android.gms:play-services-base:11.6.0 (*)
< | +--- com.google.android.gms:play-services-basement:11.6.0 (*)
< | +--- com.google.android.gms:play-services-tasks:11.6.0 (*)
< | \--- com.google.android.gms:play-services-location-license:11.6.0
---
> | +--- com.google.android.gms:play-services-gcm:+ -> 11.0.4 (*)
> | +--- com.google.android.gms:play-services-analytics:+ -> 11.0.4 (*)
> | \--- com.google.android.gms:play-services-location:+ -> 11.0.4
> | +--- com.google.android.gms:play-services-base:11.0.4 (*)
> | +--- com.google.android.gms:play-services-basement:11.0.4 (*)
> | \--- com.google.android.gms:play-services-tasks:11.0.4 (*)
That diff is going in reverse direction, but it is interesting. It could be due to play-services stuff?
Not sure what is causing this. Happens on my phone and in an emulator, both on the latest available versions.
Crash logs from emulator