[course search] Cancel button in search bar only visible when focused

[hawkrives]

Follow-up to #2770

• If you hit Cancel, which isn't always available (you have to have the search box focused first), you are returned to the overview
• If you dismiss the keyboard by scrolling, the cancel buttons goes away (because you aren't focused in the search box anymore)
• ~If you clear the search query, you do not enter "browse" mode (should this be a different issue?)~ (Resolved in #2781 )

Idk.

[hannesmcman]

I think the third one could be a separate issue... especially since the absence of the cancel button when the search bar isn't focused is only an issue on iOS.

[hannesmcman]

Fixing the "cancel button not always visible" issue might have to go upstream to https://github.com/umhan35/react-native-search-bar

[hawkrives]

so stream of consciousness

what if

• the content area is the welcome screen
• no big title (aw; saves us needing to hide it)
• if you start searching, results show up and hide the welcome content
• if no results, say so – don't show welcome content if search is active
• implement "browse" via special "match all" filter to avoid a separate mode?

thoughts? elaboration requests?

[hannesmcman]

@hawkrives Not quite sure if I can picture what you're describing...could you elaborate?

[hannesmcman]

@hawkrives Can we rename this to: "Cancel button in search bar only visible when focused"?

[hannesmcman]

I've done some digging on this..and the showsCancelButton prop of react-native-search-bar does not help us here...my guess is that there is a native prop that needs to be bridged to in order to access the functionality we want. After looking at the docs for UISearchBar, it's not clear what this prop may be. However, it must be possible since the Apple Music app has a search bar with our desired behavior:

[hawkrives]

Mail.app does, as well, fwiw

[hannesmcman]

Anybody got a friend at Apple?

[hannesmcman]

Not a problem anymore, thanks to #2790.