Followups for the rn-vector-icons@6 upgrade

[hawkrives]

Regarding #3459:

These are the matches for ios- prefixed icons in our repo:

• [x] modules/navigation-buttons/open-settings.js <Icon name="ios-settings" style={leftButtonStyles.icon} />

• [x] modules/lists/disclosure-arrow.js – no action needed; Android short-circuits before rendering the icon

• [x] source/views/home/edit/row.ios.js – no action needed; Android will never run this file

• [ ] source/views/streaming/radio/controller.js

  • [ ] icon="ios-planet"
  • [ ] <ActionButton icon="ios-play" onPress={this.play} text="Listen" />
  • [ ] <ActionButton icon="ios-more" onPress={this.pause} text="Starting" />
  • [ ] <ActionButton icon="ios-pause" onPress={this.pause} text="Pause" />
  • [ ] <ActionButton icon="ios-bug" onPress={noop} text="Error" />

• [x] modules/navigation-buttons/share.js const iconName = Platform.OS === 'ios' ? 'ios-share-outline' : 'md-share' – -outline no longer exists; need to find alternative for iOS.

• [ ] modules/food-menu/food-item-row.js const specialsIcon = Platform.OS === 'ios' ? 'ios-star' : 'md-star'

• [ ] modules/filter/filter-toolbar-button.js ios: 'ios-arrow-down',

• [ ] modules/filter/active-filter-button.js ios: 'ios-close-circle',

• [ ] source/views/streaming/radio/buttons.js icon={Platform.OS === 'ios' ? 'ios-call' : 'md-call'} icon={Platform.OS === 'ios' ? 'ios-calendar' : 'md-calendar'}

• [ ] source/views/stoprint/components/notice.js name={Platform.OS === 'ios' ? 'ios-print' : 'md-print'}

• [ ] source/views/stoprint/components/error.js ios: 'ios-bug',

We should update them to use the new helper.

[rye]

@hawkrives I have a branch with work done on almost all of these. I will work on that in the short-term.

[rye]

(I'll work on fixing this issue some more this weekend, for sure. It's on my shortlist now.)

[drewvolz]

Closed by #3598

[hawkrives]

Every item in the checklist in the OP still needs to be updated to use the helper introduced in #3459.

[drewvolz]

My bad. Thanks for reopening. @rye I've merged your PR and updated the checkboxes above 👍

[hawkrives]

I want to double-check that this is complete now