StoDevX / AAO-React-Native

The St. Olaf community, now in pocket size.
GNU Affero General Public License v3.0
42 stars 16 forks source link

Add basic snapshot tests to `notice` module using react-test-renderer #7100

Closed rye closed 7 months ago

rye commented 7 months ago

I was a bit surprised to see react-test-renderer not in the tree despite appearing in our package-lock. Why not use it if we have to download it anyhow?

For now, I'm just using snapshot tests, so any change to colors or external components will result in changes to the snapshots that must be manually reviewed.

A perhaps more useful set of tests would involve actually checking children of the root nodes.

codecov[bot] commented 7 months ago

Codecov Report

Merging #7100 (647dbd4) into master (b344a59) will increase coverage by 3.90%. Report is 4 commits behind head on master. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #7100 +/- ## ========================================== + Coverage 8.67% 12.58% +3.90% ========================================== Files 308 308 Lines 5270 5270 Branches 1421 1421 ========================================== + Hits 457 663 +206 + Misses 4786 4580 -206 Partials 27 27 ```