search

StoDevX / AAO-React-Native

The St. Olaf community, now in pocket size.
GNU Affero General Public License v3.0
42 stars 16 forks source link

Automatic disabling of the "Only Specials" filter doesn't take multiple menus into account #741

Open hawkrives opened 7 years ago

hawkrives commented 7 years ago

I think this is fallout of the menu picker PR.

hawkrives commented 7 years ago

So this is a bit trickier than it first appeared, now that we can switch between meals.

The filters apply to one menu source at a time, but the meals share the menu source (Stav, Cage, Pause, etc.)

So the "disable specials filter" logic will only look at whatever meal is the "current" meal, when the screen is opened, and won't reevaluate showing "specials only" when you change meals.

I'm thinking that we might want to add a button to that screen that disables the specials filter in one tap, to make it easier?

hannesmcman commented 6 years ago

Is this still a problem? @hawkrives

hawkrives commented 6 years ago

Yes.

To summarize, the app only decides whether or not to enable the Specials filter once, and it uses the default menu to do that (whichever one is closed to being open at the time you open the screen).

So, when you change your menu, if there aren't any specials, it'd be nice if it could automatically disable or enable tie specials filter, as needed.

With that said, I'd rather get rid of the menu picker. I've had a thing floating around in my head for a while about having the menu be ~90% of the screen width, and allowing you to simply swipe between the menus for a cafe; it could even let you swipe into the future and the past, handing the cases where we don't get any data appropriately of course.