StoXProject / RstoxFDA

Fisheries Dependent Analysis with Rstox
https://stoxproject.github.io/RstoxFDA
GNU Lesser General Public License v3.0
0 stars 1 forks source link

Consider explicit declaration of landings partitions in AnalyticalRatioEstimate #125

Open edvinf opened 3 months ago

edvinf commented 3 months ago

In current pre-release (-9006) of analytical Ratio estimate, correspondance between stratum and PSU-domains is done automatically, and an error is raised if no correspondances are found in terms of column names, or if no code correspondences are found between estimates and landings. This makes it difficult for users to spot potential misconfigurations. They should rather be excplicitly declared, similar to how fixed effects in Reca are declared.

edvinf commented 3 months ago

This can also be used to allow RatioEstimates with TotalDomainWeight to ignore some stratification columns. Consider if that is desirable, or if LiftStrata need to be exposed to StoX.

edvinf commented 2 months ago

Could also consider adding explicit imputation-function post estimate.

edvinf commented 2 months ago

Summary of dicussion with user:

edvinf commented 2 months ago

Consider:

edvinf commented 1 month ago

Note that lottery data from 2019 and 2020 only have sampling weights, not exact probabilities. AnalyticalRatioEstimate with MeanDomainWeight needs to work for these data. That is complicated by: