search

StoXProject / RstoxFDA

Fisheries Dependent Analysis with Rstox
https://stoxproject.github.io/RstoxFDA
GNU Lesser General Public License v3.0
0 stars 1 forks source link

restructure PSU design variables as input files #127

Open edvinf opened 2 months ago

edvinf commented 2 months ago

In current pre-release of RstoxFDA (1.30-9006), PSU design variables are treated as resource files, although they are not re-usable between projects. They are specific to each execution of the sampling program for a specific fishery. They should probably be treated as input files, similar to how biological records and landing data is provided.

edvinf commented 2 months ago

Make sure that some guard is added to ensure that users are not mistakenly using old files when copying projects from previous years. Perhaps make year explicit as a stratification column in data preparation.

edvinf commented 2 months ago

These are sampling parameters for data recorded in biotic files. So one natural option would be to simply store them in the existing directory "biotic". Another natural option would be to store them in a new directory, called "design".

edvinf commented 1 month ago

Discussion with AJH and EJ on Oct 21 reaffirmed that we want this as input data, rather than resource files. We decided on the option og storing sampling parameters for biotic data in the biotic data file. No changes are necessary for any other StoX packages. Rework PSU sampling parameters as input data, and not process data. Make the convention about where to locate files clear. Put that path as an example in the function documentation reading them in, and give explicit instructions in vignette.