search

StoXProject / RstoxFDA

Fisheries Dependent Analysis with Rstox
https://stoxproject.github.io/RstoxFDA
GNU Lesser General Public License v3.0
0 stars 1 forks source link

JSON schema validation fails when CarNeighbours contains CarValue instead of CarValues #90

Closed arnejohannesholmin closed 10 months ago

arnejohannesholmin commented 1 year ago

There seems to be a discrepancy between the JSON schema of CarNeighbours in (processDataSchema.json), which requires the element "CarValues" (plural), and the loadCarNeighboursFile() used by DefineCarNeighbours(), which reads "CarValue" (singular), and possibly other functions.

The consequence is that a project.json with "CarValue" does not open in StoX.

edvinf commented 10 months ago

I will standardize on 'CarValue'. Since both are used by different function, and since 'CarValue' is semantically more appealing, since the table maps one CarValue to one or more neighbours. I will leave downstream functions and the schema accepting both variants.

edvinf commented 10 months ago

I will standardize on 'CarValue'. Since both are used by different function, and since 'CarValue' is semantically more appealing, since the table maps one CarValue to one or more neighbours. I will leave downstream functions and the schema accepting both variants.