StoXProject / RstoxFDA

Fisheries Dependent Analysis with Rstox
https://stoxproject.github.io/RstoxFDA
GNU Lesser General Public License v3.0
0 stars 1 forks source link

strict spatial algorithms #93

Closed edvinf closed 1 year ago

edvinf commented 1 year ago

RstoxFDA::appendAreaCode was refactored a while back to get rid of rgdal and rgeos dependencies. The new version is a bit stricter and occasionally gives errors with points not being found strictly within polygons. It contains a strict-option to turn this of, but that does not fix it, only replace an error with a warning, leaving some areas as NA. Also the strict-option is turned on in AddStratumStoxLanding (but not in AddStratumStoxBiotic).

  1. Turn off strict in AddStratumStoxLanding
  2. Try to find a way to introduce some tolerance, so that the problem disappears.
edvinf commented 1 year ago
  1. Will be addressed by PR #96
  2. Needs some reproducable examples.