search

StochSS / GillesPy2

Modeling toolkit for biochemical simulation
http://gillespy2.readthedocs.io/
GNU General Public License v3.0
72 stars 32 forks source link

Should not give warning about Cython on "import gillespy2" #17

Closed briandrawert closed 5 years ago

briandrawert commented 6 years ago

Don't show the error unless they import "optimized_solver" directly.

briandrawert commented 5 years ago

Is this fixed now? If so, please close.

briandrawert commented 5 years ago

update:

When I use the "test/TestingBattery" notebook, I get: 

/usr/local/lib/python3.6/site-packages/Cython/Compiler/Main.py:367: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /Users/bdrawert/Desktop/research/GillesPy2/gillespy2/solvers/cython/cython_ssa_solver.pyx
  tree = Parsing.p_module(s, pxd, full_module_name)
2018-12-21 12:31:26,489 - root - WARNING -  Unable to use Cython optimized SSA: Building module gillespy2.solvers.cython.cython_ssa_solver failed: ["distutils.errors.CompileError: command 'clang' failed with exit status 1\n"]. The performance of this package can be significantly increased if you install Cython.
Thisisnotdalton commented 5 years ago

Based on our earlier discussions about warning the user when the package could be optimized with additional packages, I thought that we wanted to provide this warning on initial import?