search

StochSS / GillesPy2

Modeling toolkit for biochemical simulation
http://gillespy2.readthedocs.io/
GNU General Public License v3.0
71 stars 31 forks source link

EventAssignment: need flag, "round_discrete_populations" #710

Open briandrawert opened 2 years ago

briandrawert commented 2 years ago

(maybe workshop the name, long might not be bad)

Also, in both TauHybridSolver and TauHybridCSolver should round() discrete populations in event assignment.

suggestion from @kevinsanft: "round_discrete_populations"

briandrawert commented 2 years ago

@BryanRumsey's idea: value of flag could be True, "floor", "ceil", or "round".

briandrawert commented 1 year ago

This is easier to implement by the users in the event assignment floor(A + 0.5)

briandrawert commented 1 year ago

Need a good test case for this problem, won't fix until we find that. This might be better reworded as a configurable global of how continuous species are converted to discrete species (currently only round()).