search

StoglRobotics / sr_manipulation

Contains manipulation related packages for ROS 2
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

send_move_request does not seem like doing anything #3

Open Xi-HHHM opened 11 months ago

Xi-HHHM commented 11 months ago

https://github.com/StoglRobotics/sr_manipulation/blob/1e54bc9a666c211fac0dd8bc7b65ee65101b0c9d/sr_moveit2_utils/sr_moveit2_utils/robot_client_node.py#L619

Only a variable of the velocity factor is defined.

Xi-HHHM commented 11 months ago

I generally don't like the coding style of the robot client (and I generally don't say it out loud). It might be okay for self-development, but it is not team-friendly at all since the majority of functions do not have a doc string to explain what this function does.