StoneBlue / ASET-Consolidated-Avionics

1 stars 2 forks source link

Altimeter object names are 'incorrect' compared to expectation #5

Open wile1411 opened 9 months ago

wile1411 commented 9 months ago

As per the KSP Wiki: (If the altimeter was metric and not feet) An Earth based aircraft altimeter reading would be: Long Hand reads 100m. Short Hand reads 1,000m. *And the Inverted Triangle hand reads 10,000m.

Example_altimeter

In KSP the triangle hand reads 100m In fact all three needles are labelled 'incorrectly' when compared to the expectation of commercial altimeters. The Long Hand with the inverted triangle at the end reads 100m. The Long Hand reads 1,000m. *And the Short Hand reads 10,000m.

This was probably done for the ASET prop to replicate the behaviour of the stock KSP altimeter

In both the ASET_ALTIMETER.mu and ASET_ALTIMETER_Adv.mu models would need updating.

object name (and data properties name) ALT10_arrow renamed to ALT1000_arrow object name (and data properties name) ALT100_arrow renamed to ALT10_arrow object name (and data properties name) ALT1000_arrow renamed to ALT100_arrow

I used the very old version of Blender 2.83 and the .mu import plugin found on the KSP forum. After I renamed the object and mesh to the correct names and exported the new .mu files, it inflated the file to double the size. Clearly not the right tool - despite it 'working' in the game

ASET_ALTIMETER.mu old size 45kb new size 79kb ASET_ALTIMETER_Adv.mu old size 76kb new size 160kb

Github won't allow me to attach a copy of my blender edited version of both altimeters (Basic and Advanced) I'm guessing you don't want those test mu files (can email if needed), but I figure you'd prefer to not use them.

Hoping you have a model editing tool better than my 'hack and slash' attempt

Lastly:

As it might be confusing to have two altimeters behave differently with ASET avionics mod installed, an additional MM cfg patch is suggested to bring the stock Altimeter inline with the proposed change for the ASET prop. @PROP[AltimeterThreeHands] { @MODULE[InternalAltimeterThreeHands] { @hand100Name = MediumArm @hand1000Name = ShortArm @hand10000Name = LongArm } }

wile1411 commented 9 months ago

Easier option: change line 23 to: controlledTransform = ALT100_arrow

Add line into 34: controlledTransform = ALT1000_arrow

change line 46 to: controlledTransform = ALT10_arrow

For the ASET_ALTIMETER_Adv.cfg The respoective lines would be: Line 24: controlledTransform = ALT100_arrow Line 36: controlledTransform = ALT1000_arrow Line 48: controlledTransform = ALT10_arrow