search

StoneLabs / working-graves

They are graves. They work. Fabricmc mod.
5 stars 3 forks source link

Trinkets compatibility #3

Closed SanityCh3ck closed 1 year ago

SanityCh3ck commented 1 year ago

Items in Trinket slots are not put into graves and instead dropped on the ground.

StoneLabs commented 1 year ago

What mods are you using for the trinket slots?

SanityCh3ck commented 1 year ago

I'm using Backpacked and Bewitchment

StoneLabs commented 1 year ago

Alright. I can't promise to fix it soon, but if i find some time i'll look into it.

SanityCh3ck commented 1 year ago

Trinkets drops all of its items directly according to its own drop rules via this code right here. All other grave mods I looked at had some special handling for Trinkets, so it doesn't seem like any implicit solution without an optional dependency is viable.

StoneLabs commented 1 year ago

Yikes that sure is annoying ngl.

I will consider doing it, but not in the near future. PRs are welcome if they're not too complicated as I'd need to make sure it works after each mc update.