search

StoneLabs / working-graves

They are graves. They work. Fabricmc mod.
5 stars 3 forks source link

Respect keepInventory #8

Closed SanityCh3ck closed 1 year ago

SanityCh3ck commented 1 year ago

This one is kind of silly, but currently the keepInventory gamerule is ignored. This aims to fix that.

My suggestion would be to simply skip the item part of grave creation if the gamerule is active, but to still populate the sign and spawn the lightning. Alternatively, grave creation could be skipped entirely.

Not sure why the diff looks so weird, all I did was add an if statement...

StoneLabs commented 1 year ago

I've refactored it a bit, but have no testing environment (or any form of IDE actually) available right now.

Could you review the changes before I merge this?

SanityCh3ck commented 1 year ago

Apparently I can't approve my own pull request, but everything works just as well as before,

I don't have any more issues or PRs currently, so a release for 1.19.2 would be much appreciated :)

StoneLabs commented 1 year ago

I don't have any more issues or PRs currently, so a release for 1.19.2 would be much appreciated :)

I'll probably find time for this on the weekend. If you preferred a faster release, feel free to make a PR for v1.4.