Fix tests and restore #12

StoreDev / StoreLib

Storelib is a DotNet library that provides APIs to interact with the various Microsoft Store endpoints.

Mozilla Public License 2.0

139 stars 47 forks source link

Fix tests and restore #12 #17

Closed rtm516 closed 2 years ago

rtm516 commented 2 years ago

This reverts commit 2daf2f8b0aa77d1ccbecd97ad70ee970087bcc71 back to adding thd changes in #12.

I don't understand why #12 was merged and then reverted.

TitleOS commented 2 years ago

Building the PR fails: https://github.com/StoreDev/StoreLib/actions/runs/1802187786.

There is no argument given that corresponds to the required formal parameter 'MSAToken' of 'FE3Handler.SyncUpdatesAsync(string, string)'. Looks like when the MSAToken was made a variable, it wasn't passed to the functions on FE3Tests.cs. If you can correct that, I would be more than glad to remerge the PR. Thanks!

rtm516 commented 2 years ago

Ah no problem, I forgot to even look at the tests

TitleOS commented 2 years ago

Looks great. Everything builds and the tests pass. Thank you for correcting that issue and thank you for your contribution, merging! (hopefully for the final time heh).