Storingo / MI-449-SS17-740-html-more-kinds-of-content-OSB7Pe

0 stars 0 forks source link

Project Feedback #1

Open Storingo opened 7 years ago

Storingo commented 7 years ago

@KatieMFritz Can you take a look at this? It's hosted here and meets the following criteria:

KatieMFritz commented 7 years ago

Pretty close!

Valid HTML

I ran your published page URL through the W3C validator and it returned one error. Try it yourself and see if you can fix it. Valid HTML is required for every project now, per the instructions in this previous project.

Table Markup

When I look at the code, I see that you're using th for every cell. th is short for table header and should only be used for the first row of a table. The rest of the cells should use td for table data. You can see more details on page 2 of the lesson. If you did that on purpose, to make all the table content bold, that's something you'll want to use CSS for in the future. Let me know if you have any questions about that.

Thank you for your flattering haiku! 😊

Storingo commented 7 years ago

I made the required changes

KatieMFritz commented 7 years ago

Great! 🌟

:shipit:

One thing I missed before - looks like you got creative and used br to split text lines and make your table columns narrower. It's fine for now. In future lessons, we'll get deeper into using CSS to make layout and style changes. Once we do, you'll want to always use CSS to change things like width, and only use br to indicate that the lines are semantically separate. Does that make sense?