search

StorjOld / storjnode

Low level storj protocol reference implementation.
http://storj.io
MIT License
15 stars 6 forks source link

Crash Report from Robin #52

Open F483 opened 8 years ago

F483 commented 8 years ago

Client crashed at 4:30am. ​> @f483: One of the other clients is sending me a value to store that causes it to freeze when repeating those values back to console.

015-12-23 04:30:01,789 DEBUG storjnode.network.protocol 115: no response from 124.168.87.199:1027, removing from router
2015-12-23 04:30:01,789 CRITICAL twisted 154: 'Did not received reply for msg id vQhsct/t9AfEooz9xcBIhigMUic= within 5 seconds'
2015-12-23 04:30:01,789 CRITICAL twisted 154: 'Did not received reply for msg id vQhsct/t9AfEooz9xcBIhigMUic= within 5 seconds'
2015-12-23 04:30:01,790 DEBUG storjnode.network.protocol 115: no response from 85.236.151.157:63147, removing from router
2015-12-23 04:30:01,790 INFO storjnode.network.server 152: setting '

This may be an upstream kademlia big as the last output comes from here https://github.com/bmuller/kademlia/blob/master/kademlia/network.py#L152

However without additional info its very hard to tell what happend as the log cuts off at exactly the part we need (the respective key value pair).

subwolf commented 8 years ago

Unfortunately the only way to know is to dump out the values to be stored as they come in, otherwise nothing is known until its too late.

robertsdotpm commented 8 years ago

I added a fix that only allows printable ASCII characters and converts everything else to hex before displaying it in the log. Should avoid having strange unicode characters messing everything up for store requests.

self.log.debug("setting '%s' = '%s' on network" % (safe_key, safe_value))

Was blindly printing binary.

subwolf commented 8 years ago

Looking forward to using it, beautiful.

F483 commented 8 years ago

@robertsdotpm you made a pull request for the fix to the wrong repo. My repo only has the python 3 port so I would rather not mix anything in accept that.

Upstream pull requests should go here https://github.com/bmuller/kademlia/

I will also make some unit tests to handle all sorts of input for the DHT and see if I can find the bug.

robertsdotpm commented 8 years ago

Thanks. I've submitted a pull upstream. Hopefully it gets accepted

F483 commented 8 years ago

duplicate at https://github.com/Storj/dataserv-client/issues/188