Storm-Labs-Inc / cove-contracts-boosties

Core smart contracts of the Cove Protocol
Other
18 stars 6 forks source link

fix(YAUDIT-COVE-4): clarify overflow behaviour #307

Closed alphastorm closed 7 months ago

alphastorm commented 7 months ago

Describe your changes

Checklist before requesting a review

github-actions[bot] commented 7 months ago

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results. Summary

github-actions[bot] commented 7 months ago

Changes to gas cost

Generated at commit: d4324e5e84fe9ba937799d0fb25a86b872d76795, compared to commit: 70a6a847f80d5a27371b17f007b37a4f66252f9e

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %

Full diff report 👇
| Contract | Deployment Cost (+/-) | Method | Min (+/-) | % | Avg (+/-) | % | Median (+/-) | % | Max (+/-) | % | # Calls (+/-) | |:-|-:|:-|-:|-:|-:|-:|-:|-:|-:|-:|-:| | **ERC20RewardsGauge** | 3,604,944 (0) | _depositRewardToken_ | 7,707 (0) | **0.00%** | 148,106 (-45) | **-0.03%** | 147,383 (0) | **0.00%** | 195,467 (0) | **0.00%** | 4,610 (0) | | **YearnGaugeStrategy** | 1,817,865 (+15,315) | _approve_
_deposit_
_redeem_
_report_
_withdraw_ | 49,303 (0)
30,717 (0)
293,599 (0)
58,515 (0)
74,620 (0) | **0.00%**
**0.00%**
**0.00%**
**0.00%**
**0.00%** | 49,383 (+1)
291,889 (+7)
300,266 (+1)
302,966 (+6)
176,090 (+30) | **+0.00%**
**+0.00%**
**+0.00%**
**+0.00%**
**+0.02%** | 49,399 (0)
308,482 (0)
298,435 (0)
69,644 (0)
201,040 (0) | **0.00%**
**0.00%**
**0.00%**
**0.00%**
**0.00%** | 49,411 (0)
447,268 (0)
308,756 (0)
914,862 (0)
256,348 (0) | **0.00%**
**0.00%**
**0.00%**
**0.00%**
**0.00%** | 512 (0)
7,938 (0)
769 (0)
5,890 (0)
1,792 (0) | | **RewardForwarder** | 936,966 (0) | _forwardRewardToken_ | 8,239 (0) | **0.00%** | 111,756 (-16) | **-0.01%** | 158,199 (0) | **0.00%** | 165,062 (0) | **0.00%** | 1,280 (0) | | **YearnStakingDelegate** | 3,639,792 (0) | _harvest_ | 24,054 (0) | **0.00%** | 311,371 (-8) | **-0.00%** | 352,133 (0) | **0.00%** | 431,958 (0) | **0.00%** | 1,803 (0) | | **GaugeRewardReceiver** | 1,428,645 (0) | _harvest_ | 5,864 (0) | **0.00%** | 293,137 (-7) | **-0.00%** | 350,867 (0) | **0.00%** | 455,946 (0) | **0.00%** | 2,058 (0) |
codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.56%. Comparing base (70a6a84) to head (1bdda94).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #307 +/- ## ======================================= Coverage 97.56% 97.56% ======================================= Files 19 19 Lines 987 987 Branches 202 202 ======================================= Hits 963 963 Misses 1 1 Partials 23 23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.