search

StormSurgeLive / asgs

The Automated Solution Generation System (ASGS) provides software infrastructure for automating coastal ocean modelling for real time decision support, and provides a variety of standalone command line tools for pre- and post-processing. Visit us at https://discord.gg/jFbacxrUf9
https://tools.adcirc.live
GNU General Public License v3.0
39 stars 22 forks source link

support all `hookScripts` keys directly (don't force configs to use `hookScripts[...]` directly) #1385

Open wwlwpd opened 1 month ago

wwlwpd commented 1 month ago

Turn this,

hooksScripts[FINISH_SPINUP_SCENARIO]=" output/createOPeNDAPFileList.sh output/$OPENDAPPOST "
hooksScripts[FINISH_NOWCAST_SCENARIO]=" output/createOPeNDAPFileList.sh output/$OPENDAPPOST "
...

into this,

FINISH_SPINUP_SCENARIO=( output/createOPeNDAPFileList.sh output/$OPENDAPPOST )
FINISH_NOWCAST_SCENARIO=( output/createOPeNDAPFileList.sh output/$OPENDAPPOST )
...

Which is how POSTPROCESS=( ... ) is currently handled.

jasonfleming commented 1 month ago

I agree, I like this better. The way it is now is just what I thought of first.

wwlwpd commented 1 month ago

I've been wanting to make this consistent for a while, "raw" access is fine for what we do here. It's a good time to make it consistent, though. I can't really blame this for me forgetting to add it in the latest configs.