StormSurgeLive / asgs

The Automated Solution Generation System (ASGS) provides software infrastructure for automating coastal ocean modelling for real time decision support, and provides a variety of standalone command line tools for pre- and post-processing. Visit us at https://discord.gg/jFbacxrUf9
https://tools.adcirc.live
GNU General Public License v3.0
39 stars 22 forks source link

enable asgs to handle version differences in adcirc and adcirc+swan #228

Open jasonfleming opened 4 years ago

jasonfleming commented 4 years ago

Different versions of ADCIRC and SWAN have different requirements for input. Some things that were required in older versions are now forbidden, and vice versa. These changes include the following:

  1. wave_refraction_in_swan nodal attribute
  2. initial_river_elevation nodal attribute
  3. courant limiter on spectral propagation velocities in swan
  4. meaning of IM value in v53 vs v54, specifically regarding Smagorinsky lateral viscosity

These differences need to be catalogged and then systematically accounted for in the scripts that generate ASGS input files.

wwlwpd commented 4 years ago

Ok, sounds like an important capability. Where would you place this in terms of priority wrt this season's operations?

wwlwpd commented 4 years ago

The basic proposal for this is to enhance the initadcirc tool to allow for easier switching and adding Environmental variables that will communicate to ASGS what sorts of ADCIRC related features are enabled or not enabled.

The "hard" part will be making ASGS aware of these feature options in a clean and extensible way.

Longer term, adcircctl could also be used as a wrapper around generating the fort.15, etc. Hiding all of that complexity (in an sane way) behind adcircctl would allow core ASGS scripts to be much cleaner.