Fix regression in 0.2.0, rework logic for clarity

Stormbase / django-otp-webauthn

Passkey support for Django. Currently in early stages of development and not ready for production use!

BSD 3-Clause "New" or "Revised" License

10 stars 2 forks source link

Closed Stormheg closed 1 month ago

Stormheg commented 1 month ago

Fixes #10

Replaces #11

While reviewing #11 and the surrounding code I wrote a couple months ago, I noticed some opportunities for improvement.

Some of the checks to see if we should allow authentication to proceed were duplicated among AuthenticationCeremonyMixin and the CompleteCredentialAuthenticationView. This PR addresses that.
Raise exceptions directly instead of a 'catch all' exception based on the return value of some boolean
Clean up (now) unused exception classes

Stormheg commented 1 month ago

@jmichalicek would you like to review this?