[Item] Greater Cache of Treasures from scenario rewards lacks class-specific loot conditions

Gubbyfishy commented 10 months ago

Description: The containers awarded from completing a random scenario should only drop loot relevant for the player's class (not spec-specific like the heroic caches). As an example, this could entail:

Paladins should not be able to get leather, only plate
Warriors should get plate, but not plate items with intellect
Hunters should get mail only with agility affixes
Rogues obtain leather with only agility
Monks obtain leather with both agility and intellect affixes

https://www.wowhead.com/item=92813/greater-cache-of-treasures#comments:id=1769444 - Upvoted comment mentioning this behaviour for the 5.1 cache (yes, the greater cache is a 5.1 addition. The original item was Cache of Treasures, removed in 5.1, with the inability to drop epic items and 463 rare weapons) https://www.wowhead.com/item=89613/cache-of-treasures#comments:id=1702251 - Upvoted comment mentioning this behavior for the cache added in 5.0.4 https://warcraft.wiki.gg/wiki/Scenario - Mentioned on the Warcraft Wiki as having drop conditions too

As an added example, Satchels of Helpful Goods awarded from the lower level random dungeon rewards follow a similar condition/rule, but this is not addressed either on Mistblade as of yet.

Current behaviour: Greater Cache of Treasures does not follow class-specific loot conditions.

Expected behaviour: Greater Cache of Treasures should only drop items relevant to the class.

ythealien commented 10 months ago

Also evidenced in https://github.com/Stormforge-gg/Bugtracker-Mistblade/issues/914

Gubbyfishy commented 9 months ago

For what it's worth, while most likely inapplicable on your end, I know issues such as this are fixed in the conditions table on TrinityCore, as well as slight adjustments to the container's loot references.

Rather than what I assume is having all item entries in the same reference, multiple references for each armor type and affix pool could be an option, with conditions making excess drops invisible for classes items are 'unusable' for.

I don't expect this to be the defacto fix in this scenario (no pun intended), but it may help you towards finding an approach for a fix.

Stormforge-gg / Bugtracker-Mistblade

[Item] Greater Cache of Treasures from scenario rewards lacks class-specific loot conditions #1539