[Spell][Shaman] Healing Rain is incorrectly snapshotting haste effects.

[nullKomplex]

Description: Haste should not be snapshotting when placing Healing Rain. This occurs regardless of whether of not the player is talented into Conductivity. This is resulting in some weird cheese playstyles for resto shamans that should not exist.

Current behaviour: Haste is snapshotted when Healing Rain is cast, even if talented into Conductivity and extending the duration.

Expected behaviour: Haste should update dynamically.

Logs disproving Conductivity snapshotting: https://www.warcraftlogs.com/reports/Vj8Gbp3ynCxrgHwd#fight=29&type=healing&source=4 During the three Healing Rains affected by haste effects (Bloodlust and Berserking twice) the following occurs: Healing Rain cast at 35s - 0.97 interval between ticks during lust and 1.3005 after it's fallen Healing Rain at 1:16 - 1.068 interval between ticks during zerk and 1.311 outside of Healing Rain at 4:15 - 1.093 during zerk and 1.381 outside

https://www.warcraftlogs.com/reports/LYBcknTVaMGdQ3Nw#fight=47&type=healing Healing Rain cast on pull - 1.035 during lust and 1.305 after it ends. Notably I inspected this log specifically and noticed that there were 10 casts of Chain Heal well before lust had ended and still the time between ticks immediately increases after lust fades. This means it should update dynamically and not on refresh.

Logs disproving snapshotting normally: https://www.warcraftlogs.com/reports/hK3Yck69fqHQRLWz#fight=33&type=healing&source=24 Healing Rain cast at 24s and 35s - 1.011 during lust and 1.293 after despite both being cast with lust active Healing Rain cast at 1:10 and 1:22 - 1.206 during and 1.3 after. This could be within margin of error.

https://www.warcraftlogs.com/reports/AWxNL2khPf3cYnRv#fight=42&type=healing&source=11 Healing rain cast at 3:07 and 3:20 - 1.05 during lust and 1.291 before. Both were cast before lust was active. Healing rain cast at 3:48 and 4:01 - 0.983 during lust and 1.322 after. Both were cast while lust was active.

Do note that all calculations were done ignoring ticks on the caster of the healing rain, as retail handles self healing different than external healing.

[nullKomplex]

I didn't label everything appropriately but this is the spreadsheet I used while figuring out the behavior: https://docs.google.com/spreadsheets/d/1M0Et9EGZbcqJEKkbBC88onZDbUs3BDkO32cu6UKLbVM/edit?usp=sharing

I've also heard that druid Efflo is snapshotting haste which doesn't sound right to me either. But I'm a little worn out after researching this bug very thoroughly.

[malvanis]

Shamans have felt generally overpowered in terms of air healing due to how strong healing rain is especially on 25man. If this is correct it would go a long way to bringing them back in line with other healers for the better players and significantly buff the spec for people ignoring the snapshotting.

[query-wow]

@nullKomplex please check the PTR. I'll push a fix and on monday will ask Chris to update it

[Stiwlk]

Guys, why are you trying to fix something you don’t understand. Go into the game and see what you've done, I'm ashamed of you

Why can I keep it raining for 4 minutes?) And do you understand how the mechanics of spell dynamics should work?

Dynamic means that whenever I have an additional spell haste buff on me, my spells AUTOMATICALLY gain haste for the duration of the buff. In our case, you made it so that every time I get an additional spell haste buff, I have to cast the spell again for that haste to work. This does not fit the concept of dynamics at all.

[query-wow]

Fix was reverted due to 2 new side effects

[Foodlenz]

Something still broken with this. Got a permanent healing rain down that's not doing anything at all besides making the ground blue.

[query-wow]

I think it's a visual bug @Foodlenz

[Foodlenz]

If it was just on the ground then maybe, but the aura was still applied and not correctly canceling itself once the duration timed out (you can see it at the top with my other buffs).

I ended up right clicking it to cancel it off, but it shouldn't happen.