[PvP] Battleground Queue Logic is Broken

[Skipslegdays]

Copying this from Tauri since servers share the same code.

The backend code assigning players to battleground teams is broken.

https://tauriwow.com/armory#pvp-match.xml?r=%5BEN%5D%20Evermoon&matchid=869183

Here’s how this game below went:

• Started as 6 Alliance vs 7 Hordes
• Alliance started winning and because the server is full of castrated monkeys, two hordes quit
• Now the game is 6 v 5
• However, at the end of the battleground, the game became 6 Alliance vs 8 Horde, even though no Alliance quit

Common sense says Horde should not be allowed an eighth player until the Alliance has their seventh. One of three things might have happened to result in this clown fiesta

• Three people queued very quickly. And instead of the backend code going “I give the BG enter prompt to one player at a time,” it was given to all three at the same time and all to Horde.
• A premade of three people queued, and the game sent them to the side with fewer people. This shouldn’t happen; premade shouldn’t allow you to break the numbers balance
• Four or more people queued, some got assigned Alliance, some Horde. The game thinks “I just assigned two people Alliance, so I’ll let three Hordes in” even though the Alliance people didn’t end up accepting queue.

[hearthn]

That's not a bug. A disparity of at least 1 is permitted. It might be a % of max team size and larger in 15/40-man bgs, but it's at least 1 in 10-man bgs.

Actual timeline:

• The game counts queues popped as players (which is blizzlike)
• Queue pops for 1 alliance and 3 hordes
• Game becomes 6(+1) v 5(+3), aka 7v8 which is within the disparity permitted
• The alliance player doesn't accept the queue, which results in the game being 6v8

Not a bug unless you can somehow prove that literally nobody got a queue pop to play as alliance in that time frame.