search

StorminStanley / st2workroom

Vagrant environment used to play with StackStorm, develop StackStorm for your environment, or develop on StackStorm itself!
Apache License 2.0
23 stars 21 forks source link

Dockerized Hubot #271

Closed jfryman closed 8 years ago

jfryman commented 8 years ago

This PR updates Hubot in the AIO install to be dockerized, and accompanies https://github.com/stackstorm/docker-hubot

jfryman commented 8 years ago

NOTE: This PR Can not merge until a migration is put in place to account for pre-docker hubot configurations. Best we can do is cleanup mess.

jfryman commented 8 years ago

@lakshmi-kannan and I had a discussion yesterday about merging in features such that they are not mandatory for a user to have enabled. (e.g.: Dark Ship + Feature Flags). This allows us to push out new code without breaking the world and keeping open long-running branches.

Anyway, I was reflecting on my note last night

This PR Can not merge until a migration is put in place to account for pre-docker hubot configurations. Best we can do is cleanup mess.

And realized that this PR pretty much violates the spirit of what we spoke about. So, I've updated this PR to be an actual feature flag that must be enabled until such time that we deem it :ok_hand: and flip the bit permanently.

https://github.com/StackStorm/st2workroom/commit/9319679888f782b95d5805dcd74765519a4f1ae8

jfryman commented 8 years ago

Can I please get some :eyes: on this? Want to ensure this can safely be merged while we continue to iterate. Am I missing anything?