search

StorminStanley / st2workroom

Vagrant environment used to play with StackStorm, develop StackStorm for your environment, or develop on StackStorm itself!
Apache License 2.0
23 stars 21 forks source link

Make mongodb container to listen on localhost only #299

Closed fatganz closed 8 years ago

Kami commented 8 years ago

Thanks.

The change looks reasonable to me, but I'm not fully sure how this will affect the whole installation. We need to make sure other services can still talk to MongoDB.

In any case, I will wait for someone with more experience with this to chime in :)

fatganz commented 8 years ago

Just keep in mind that mongo container is exposed to the internet on freshly provisioned machines without authentication. So it would be really nice to fix this issue.

jfryman commented 8 years ago

@fatganz nice, thanks for the change. Any issues on your end after this change?

It shouldn't affect anything, since everything connects on localhost by default, but would love to just get a quick gut-check before merging.

fatganz commented 8 years ago

@jfryman So far there're no issues for me

jfryman commented 8 years ago

@fatganz :metal: We'll keep an eye on things and run through tests. Thanks again for the code and safety! :heart: :lock:

estee-tew commented 8 years ago

https://stackstorm.slack.com/archives/stackstorm/p1450887659018288