search

StorminStanley / st2workroom

Vagrant environment used to play with StackStorm, develop StackStorm for your environment, or develop on StackStorm itself!
Apache License 2.0
23 stars 21 forks source link

Fix hubot not reconnecting after st2ctl restart #303

Closed enykeev closed 8 years ago

enykeev commented 8 years ago

When st2api is down, instead of 502 nginx will start returning special pages for custom resources and 404 for everything else.

In case of steam custom resource page, by changing retry value you can actually tell hubot how long it should wait before reconnecting.

emedvedev commented 8 years ago

404 doesn't seem accurate since API being down is not just "not found" but a genuine server error. How about HTTP 500?

enykeev commented 8 years ago

It's 404 now because we don't have custom answer in @errors location for anything except of /steam. The fix is outside the scope of that PR.

emedvedev commented 8 years ago

Would it be difficult to have a return 500; for every page except stream inside @errors? It's outside the scope, but I feel like having 404s on server errors is a bit of a regression, so it's not too hard, I'd rather fix it now.

enykeev commented 8 years ago

Honestly, I don't know how hard it would be, "I'm not a real welder", so to say.