StorminStanley / st2workroom

Vagrant environment used to play with StackStorm, develop StackStorm for your environment, or develop on StackStorm itself!
Apache License 2.0
23 stars 19 forks source link

Don't install default SSH key for stanley user #305

Closed Kami closed 8 years ago

Kami commented 8 years ago

This is st2workroom part of this change - https://github.com/StackStorm/puppet-st2/pull/143

Kami commented 8 years ago

I just included new stackstorm-st2 version (0.13.0). You can now test those changes using ENV=bump_stackstorm_st2_ssh_changes update-system

I test it by first removing private key /home/stanley/.ssh/st2_stanley_key and public key from `/home/stanley/.ssh/authorized_keys and then running update-system (no key should be added).

You can then add those lines to answers.yaml file and make sure key gets installed after running update-system again.

st2::stanley::ssh_public_key: XXXXXX
st2::stanley::ssh_key_type: ssh-rsa
st2::stanley::ssh_private_key: XXXXXX

I'm also working on some automated tests for that, but it will take a while to hook them all up.

Kami commented 8 years ago

I will go ahead and merge this.

If something terrible happens (as noted on Slack), the revert is simple - we simply need to pin stackstorm-st2 to 0.12.2 which is a version used before this change and let people know to run update-system.