search

StorminStanley / st2workroom

Vagrant environment used to play with StackStorm, develop StackStorm for your environment, or develop on StackStorm itself!
Apache License 2.0
23 stars 21 forks source link

Allow SHA or Tag to be supplied for installer #306

Closed lakshmi-kannan closed 8 years ago

lakshmi-kannan commented 8 years ago

Tested on a vagrant box and it seems to work.

estee-tew commented 8 years ago

https://stackstorm.slack.com/archives/stackstorm/p1452290452022118

manasdk commented 8 years ago

nice!

enykeev commented 8 years ago

I'm probably a little bit slow this morning, how is it different from -b [ref] besides the fact it creates a new branch? Why do we need that branch?

lakshmi-kannan commented 8 years ago

I'm probably a little bit slow this morning, how is it different from -b [ref] besides the fact it creates a new branch? Why do we need that branch?

I am confused. -b support was added by you IIRC. It's done so we can do testing in st2cd. I think -b suppport should stay. -r is now added and will be a customer facing option so they can switch to a particular tag/sha of workroom if they need to. Tags are how st2workroom will be versioned.

enykeev commented 8 years ago

What I'm trying to say is that they have basically the same functionality short of renaming the branch. If this renaming is not required and simply made for convenience, lets pick one and remove the other. Having two is confusing no matter whether we going to document -b or not.

lakshmi-kannan commented 8 years ago

If this renaming is not required and simply made for convenience,

For tags and sha, to make sure we don't get a detached HEAD state which might throw off some users, I decided to add -b some_branch_name. I see what you mean w.r.t having one as opposed to two options. I'll remove -b then :P. We need to update the st2cd workflows as well. I'll open a PR for that.

estee-tew commented 8 years ago

https://stackstorm.slack.com/archives/stackstorm/p1452574040022538

dzimine commented 8 years ago

The default should ideally be resent stable version. So curl -sSL https://install.stackstorm.com/ | sudo sh installs the latest stable version (1.3 once we release). Currently the default is 'master'

Discussed with @lakshmi-kannan and we keep it at it for now but need to revisit.

Kami commented 8 years ago

Hm, I don't know if my issue is related to this change, but just in case.

ENV=<branch name> doesn't seem to work for my anymore. Am I missing something?